feat: add custom calendar reminder for Google Calendar events by Deepak22448 · Pull Request #26078 · calcom/cal.com

Deepak22448 · 2025-12-20T08:56:55Z

What does this PR do?

Allows users to set default reminder notifications (10, 30, or 60 minutes) for events created via Cal.com bookings in Google Calendar. This addresses the issue where Google Calendar's default reminders don't apply to API-created events.

Changes:

Add customCalendarReminder field to DestinationCalendar model
Create reminder selector UI in destination calendar settings (Settings → Calendars)
Update GoogleCalendarService to apply custom reminders (popup + email)
Add TRPC endpoint for updating reminder settings

Visual Demo (For contributors especially)

Video Demo:

https://www.loom.com/share/212f7fb3beac49bdace349452730eec2

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no docs changes needed.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Connect a Google Calendar account
Go to Settings → Calendars
Set Google Calendar as your destination calendar
A "Default reminder" dropdown should appear with options: 10, 30, or 60 minutes
Select a reminder time and save
Create a new booking
Check the Google Calendar event - it should have both popup and email reminders set to the selected time

Expected behavior:

When a booking is created, the Google Calendar event includes custom reminders
Both popup and email notifications are set to the same duration

Checklist

I have read the contributing guide
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have checked if my changes generate no new warnings

vercel · 2025-12-20T08:57:01Z

@Deepak22448 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2025-12-20T08:57:02Z

All committers have signed the CLA.

cubic-dev-ai

3 issues found across 11 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/trpc/server/routers/viewer/calendars/setDestinationReminder.schema.ts">

<violation number="1" location="packages/trpc/server/routers/viewer/calendars/setDestinationReminder.schema.ts:6">
P2: Schema validation is overly permissive - allows any value 0-60 but the feature only supports 10, 30, or 60 minutes. Consider using `z.enum()` or `z.union()` with literal values to restrict to valid options, which also provides better type safety and self-documents the allowed values.</violation>
</file>

<file name="packages/platform/atoms/destination-calendar/wrappers/DestinationCalendarSettingsWebWrapper.tsx">

<violation number="1" location="packages/platform/atoms/destination-calendar/wrappers/DestinationCalendarSettingsWebWrapper.tsx:18">
P2: Use `t()` for localization instead of hardcoded strings. Import `useLocale` and use translation keys:
```typescript
const { t } = useLocale();
...
showToast(t(&quot;reminder_updated&quot;), &quot;success&quot;);
```</violation>
</file>

<file name="packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts">

<violation number="1" location="packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts:461">
P1: Test data contradicts test purpose. The test claims to verify behavior &#39;when no custom reminder is configured&#39; but sets `customCalendarReminder: 10`. To test the default reminders scenario, this should be `null` or omitted.</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Ask questions if you need clarification on any suggestion

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/trpc/server/routers/viewer/calendars/setDestinationReminder.schema.ts

packages/platform/atoms/destination-calendar/wrappers/DestinationCalendarSettingsWebWrapper.tsx

packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts">

<violation number="1" location="packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts:720">
P1: Test data contradicts test purpose. This test is meant to verify default reminders are used when **no** custom reminder is configured (`customCalendarReminder: null`). Changing it to `10` means a custom reminder IS configured, which invalidates the test&#39;s stated purpose. Either revert to `null` to test the default-reminder scenario, or update the test name and assertion to test the custom-reminder scenario.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts

Deepak22448 · 2025-12-21T05:06:57Z

@dhairyashiil can you please review my PR ?

packages/prisma/migrations/20251220034814_add_custom_calendar_reminder/migration.sql

eunjae-lee

Thanks for your contribution ! It works well.

eunjae-lee · 2026-01-08T15:55:23Z

need more approval from other team. i'll ping them.

Deepak22448 · 2026-01-08T15:56:43Z

Thanks @eunjae-lee.

packages/lib/server/repository/destinationCalendar.ts

Changed from static to instance methods with getInstance() pattern as requested in review.

…pak22448/cal.com into feat/google-calendar-custom-reminder

…custom-reminder

Deepak22448 · 2026-01-12T09:29:54Z

Hi @eunjae-lee and @keithwillcode ,

I’ve addressed all the review comments and updated the changes accordingly. Could you please take another look and review when you get a chance?

Thanks!

eunjae-lee · 2026-01-12T13:31:05Z

I’ve addressed all the review comments and updated the changes accordingly. Could you please take another look and review when you get a chance?

Hi @Deepak22448 sorry for not providing enough feedback.

#26751

here's a PR that contains more guide on how to properly create repositories / services using dependency injection. Could you follow that guide?

- Remove getInstance() singleton pattern - Add DI tokens, module, and container - Update GoogleCalendarService and tRPC handler to use DI

Deepak22448 · 2026-01-12T15:27:46Z

Hi @Deepak22448 sorry for not providing enough feedback.

#26751

here's a PR that contains more guide on how to properly create repositories / services using dependency injection. Could you follow that guide?

@eunjae-lee Thanks for the guidance! I've now refactored the code to follow the dependency injection pattern

cubic-dev-ai

No issues found across 19 files

eunjae-lee

fantastic. thanks for your contribution !

addressed

Deepak22448 requested a review from a team as a code owner December 20, 2025 08:56

pull-request-size bot added the size/L label Dec 20, 2025

cubic-dev-ai bot reviewed Dec 20, 2025

View reviewed changes

Deepak22448 mentioned this pull request Dec 20, 2025

[CAL-4716] Missing Notifications for Events #16651

Closed

github-actions bot added $20 calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Dec 20, 2025

cubic-dev-ai bot reviewed Dec 20, 2025

View reviewed changes

packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts Outdated Show resolved Hide resolved

volnei requested a review from a team as a code owner December 27, 2025 02:35

volnei added the ready-for-e2e label Dec 27, 2025

volnei reviewed Dec 27, 2025

View reviewed changes

packages/prisma/migrations/20251220034814_add_custom_calendar_reminder/migration.sql Outdated Show resolved Hide resolved

eunjae-lee added run-ci Approve CI to run for external contributors and removed run-ci Approve CI to run for external contributors labels Jan 8, 2026

eunjae-lee previously approved these changes Jan 8, 2026

View reviewed changes

algora-pbc bot added the 🙋 Bounty claim label Jan 8, 2026

keithwillcode previously requested changes Jan 9, 2026

View reviewed changes

packages/lib/server/repository/destinationCalendar.ts Outdated Show resolved Hide resolved

packages/lib/server/repository/destinationCalendar.ts Outdated Show resolved Hide resolved

Deepak22448 added 2 commits January 9, 2026 21:31

refactor: use instance methods in DestinationCalendarRepository

9337b22

Changed from static to instance methods with getInstance() pattern as requested in review.

Merge branch 'feat/google-calendar-custom-reminder' of github.com:Dee…

82cd0cd

…pak22448/cal.com into feat/google-calendar-custom-reminder

Deepak22448 dismissed eunjae-lee’s stale review via 82cd0cd January 9, 2026 16:04

Deepak22448 requested review from eunjae-lee and keithwillcode January 9, 2026 16:05

Merge remote-tracking branch 'origin/main' into feat/google-calendar-…

d9b9a2e

…custom-reminder

github-actions bot added the devin-conflict-resolution label Jan 12, 2026

Deepak22448 added 2 commits January 12, 2026 20:15

Merge branch 'main' into feat/google-calendar-custom-reminder

c404de3

refactor: replace singleton with DI for DestinationCalendarRepository

b6a0949

- Remove getInstance() singleton pattern - Add DI tokens, module, and container - Update GoogleCalendarService and tRPC handler to use DI

calcom deleted a comment from github-actions bot Jan 12, 2026

cubic-dev-ai bot reviewed Jan 12, 2026

View reviewed changes

eunjae-lee added run-ci Approve CI to run for external contributors and removed run-ci Approve CI to run for external contributors labels Jan 12, 2026

eunjae-lee approved these changes Jan 12, 2026

View reviewed changes

volnei approved these changes Jan 14, 2026

View reviewed changes

eunjae-lee merged commit 2881961 into calcom:main Jan 14, 2026
69 of 76 checks passed

keithwillcode mentioned this pull request Jan 15, 2026

feat: add custom Google Calendar reminders for booked events #23638

Closed

6 tasks

Conversation

Deepak22448 commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Visual Demo (For contributors especially)

Video Demo:

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

vercel bot commented Dec 20, 2025

Uh oh!

CLAassistant commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Deepak22448 commented Dec 21, 2025

Uh oh!

Uh oh!

eunjae-lee left a comment

Choose a reason for hiding this comment

Uh oh!

eunjae-lee commented Jan 8, 2026

Uh oh!

Deepak22448 commented Jan 8, 2026

Uh oh!

Uh oh!

Uh oh!

Deepak22448 commented Jan 12, 2026

Uh oh!

eunjae-lee commented Jan 12, 2026

Uh oh!

Deepak22448 commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

eunjae-lee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Deepak22448 commented Dec 20, 2025 •

edited

Loading

CLAassistant commented Dec 20, 2025 •

edited

Loading